search

rock-core / gui-vizkit

Rock (Robot Construction Kit) Ruby-based library to build GUIs that interact with a Rock system
http://rock-robotics.org/documentation/graphical_user_interface/index.html
5 stars 16 forks source link

fix UiLoader calling Orocos.load #44

Closed doudou closed 9 years ago

doudou commented 9 years ago

Orocos.load is a global initialization. If Vizkit needs it, it should require the user to call it for you

goldhoorn commented 9 years ago

Why not raising this should forbitten and cause strange erros.....

doudou commented 9 years ago

Read the comment.

goldhoorn commented 9 years ago

Yeah i know, but this will affect only user-scripts, backward compatibility in this case is (from my point of view) not needed here... Warnings will be ignored mostly... adding the "sainity check" we talked in the other script will break backward compatibility too...

doudou commented 9 years ago

Yeah i know, but this will affect only user-scripts, backward compatibility in this case is (from my point of view) not needed here

That's an interesting point of view. If there is one place where backward compatibility is needed, it is in end-user-scripts.

doudou commented 9 years ago

Plus, it's really cheap to keep it here. When we decide to remove it, people will have less ammo to complain.