allow setting rest api main route

doudou commented 4 years ago

CI doesn't pass ... Was /api the current default ?

g-arjones commented 4 years ago

Think so, yes.. I will see what's wrong...

g-arjones commented 4 years ago

master is failing on my setup as well.. Could you try on yours?

doudou commented 4 years ago

Will do. It passes on Travis though ... heisenbug ? https://travis-ci.org/rock-core/tools-roby/jobs/619617552

g-arjones commented 4 years ago

heisenbug ?

Don't think so.. It fails pretty consistently here... Maybe a behavior change in one of the dependencies?

doudou commented 4 years ago

Maybe a behavior change in one of the dependencies?

Sounds reasonable ...

And you're right. Error 9 here points to the problem ... Grape started defining (and calling) an "#execute" method but Roby's helpers have one too.

Since one has a block and the other not, we can workaround. Could you take care of it ?

rename #execute in /home/travis/build/rock-core/tools-roby/lib/roby/interface/rest/helpers.rb to #roby_execute
define #execute which calls super (i.e. Grape's) if there is no block and roby_execute otherwise
warn about deprecation (and point to roby_execute) in the latter case to phase execute out

g-arjones commented 4 years ago

Could you take care of it ?

Sure :+1:

g-arjones commented 4 years ago

There is a heisenbug now I guess:

arjones@tidewise:~/dev/wetpaint/tools/roby$ bundle exec ruby test/tasks/test_external_process.rb 
Roby[WARN]: debugging is disabled because the 'pry' gem cannot be loaded
Run options: --seed 2970

# Running:

.............................F..

Finished in 2.613554s, 12.2439 runs/s, 19.1310 assertions/s.

  1) Failure:
Roby::Tasks::ExternalProcess::redirection#test_0006_redirects both channels to the same file [test/tasks/test_external_process.rb:282]:
--- expected
+++ actual
@@ -1,5 +1 @@
-"E: FIRST LINE
-E: SECOND LINE
-O: FIRST LINE
-O: SECOND LINE
-"
+""

32 runs, 50 assertions, 1 failures, 0 errors, 0 skips

Passes on travis though. There is also an occasional unhandled exception in travis logs that is not reported as error, not sure these are related (see travis build logs for the various ruby versions).

I don't think neither of these are related to the ruby-grape change but I still have to figure out why REST's tests still don't pass on ruby 2.3

doudou commented 4 years ago

still don't pass on ruby 2.3

Yeah. No need. We don't have to support 2.3 anymore since 18.04 has 2.5

rock-core / tools-roby

allow setting rest api main route #142