Closed jhonasiv closed 3 weeks ago
Reading actions.rb in order to review this, I don't understand why
#missing_required_arguments
treat any delayed argument as a required one, even (it seems) when the arg is a optional one
I added a comment in action.rb that explains exactly when this happens
This fixes a bug in the test harness where syskit would be unable to deploy multiple actions together when:
The issue appeared as a failed merge attempt complaining that a Variable doesnt have the strong? method
By looking further into it, we realized that this happened because when the toplevel task shares used definitions with the sub task, they would have delayed variable references instead of the example arguments (since we dont resolve the example arguments ourselves). That way, syskit was basically trying to merge "some defined value" and "var:variable_name", which should not be possible.
The fix to that comes in two parts: