search

rock-core / tools-roby

The roby plan manager
Other
3 stars 11 forks source link

Review plan tests and extend replacement operations for filtering #83

Closed doudou closed 6 years ago

g-arjones commented 6 years ago

I'm afraid I can't help much here but I had a look and could not catch anything obvious. Tests.. Yay! 👍

doudou commented 6 years ago

I'm afraid I can't help much here but I had a look and could not catch anything obvious. Tests.. Yay! 👍

Yeah, this is getting deep in the core of Roby ... Transaction-aware graph modification is not exactly the easiest to grasp.

The depressing (but expected) part was starting to run a branch-aware code coverage library (deep-cover) and finding out how badly the branches are covered.

I'm planning on moving this code into a separate "plan transformation" namespace / zone in the codebase to isolate it more, and allow for more specific documentation of the mechanisms involved.

g-arjones commented 6 years ago

I'm planning on moving this code into a separate "plan transformation" namespace / zone in the codebase to isolate it more, and allow for more specific documentation of the mechanisms involved.

That would be awesome

doudou commented 6 years ago

I'm merging this now. It's been used "in production" for a while now.