search

rock-core / tools-syskit

Rock's model-based component management layer
1 stars 14 forks source link

feat: implement logging ruby tasks (on top of #414) #416

Closed doudou closed 3 months ago

doudou commented 3 months ago

On top of #414

This PR implements using an in-process logger for ruby tasks. The logger is disabled by default (as it would have the ability to seriously impact a system in case of bugs). One needs to set

Syskit.conf.in_process_default_logger_support = true

to enable it.

doudou commented 3 months ago

Just so that I understand, how would having a single deployment for all the in process tasks work when we have multiple in process tasks running?

Not sure I understand the question.

The mapping between deployments and in-process tasks is "free". That is, one can have more than one in one "deployment" or a single one. Obviously, just like with the ruby tasks, the deployment is virtual (it's only there to manage whether or not the task objects are created)

jhonasiv commented 3 months ago

Just so that I understand, how would having a single deployment for all the in process tasks work when we have multiple in process tasks running?

Not sure I understand the question.

The mapping between deployments and in-process tasks is "free". That is, one can have more than one in one "deployment" or a single one. Obviously, just like with the ruby tasks, the deployment is virtual (it's only there to manage whether or not the task objects are created)

That answers my question, thanks.