basic linting of manifest.xml vs orogen and CMake configuration

rock-core / vscode-rock

VSCode extension for Rock integration

MIT License

1 stars 1 forks source link

basic linting of manifest.xml vs orogen and CMake configuration #25

Open doudou opened 6 years ago

doudou commented 6 years ago

Auto-detect common missing dependencies in manifest.xml by parsing CMake and orogen configuration, examples:

orogen projects that use the transformer need to depend on drivers/orogen/transformer
dependencies added to DEPS_PKGCONFIG should have a corresponding dependency
... ?

This should possibly be an autoproj plugin instead of a VSCode thing.

g-arjones commented 6 years ago

This would be great. But how do we map library name to relative path? For example, using_library "transformer" means "drivers/orogen/transformer" is required and using_library "frame_helper" means perception/frame_helper is required..

Situation is even worse with pkg-config...

doudou commented 6 years ago

In this particular case (that's why I would like it to either be a rock-specific autoproj plugin, or a rock-vscode functionality), I would go for heuristics.

The orogen transformer plugin's source can be hard-coded to drivers/orogen/transformer

The source for the rock cmake macros is base/cmake.

The source for pkg-config: if there is a library called */<dependency_name>, assume that it should be the in <depend ...> it won't catch everything, but should catch most the use-cases.