search

rock-core / vscode-rock

VSCode extension for Rock integration
MIT License
1 stars 1 forks source link

Search in folder does not work because of name with slash #83

Closed dbcesar closed 3 years ago

dbcesar commented 3 years ago

Hello,

I installed the extension recently and I realized that the command "Find in folder..." (Shitft + Alt + F) does not work. For example, on a package like "base/types" I get the following error:

image

I made a quick search and found that this is an issue when there's slash on the "name" field (https://github.com/microsoft/vscode/issues/99512).

I manually edited the workspace json and gave a name without the slash. It works normally. This name seems to be assined when we add a package with "Rock: Add package to workspace".

Would be possible to change the way we name the folders to remove the slash by default? Do you workaround this somehow or it's a tools that you just don't use?

g-arjones commented 3 years ago

Would be possible to change the way we name the folders to remove the slash by default?

That would be possible but then telling the difference between i.e drivers/orogen/iodrivers_base and drivers/iodrivers_base would be a problem.

The good news is that https://github.com/microsoft/vscode/commit/f19a2c969bfafa1ec083677dc0281ad1765e468b apparently fixes the issue so you can either try the insiders or wait for it to be released on stable

g-arjones commented 3 years ago

Actually, there's a workaround you can use until the fix lands: use the full path to the folder you want to search in. That is, instead of ./base/types search in /home/dbcesar/dev/flat_fish/base/types :P

dbcesar commented 3 years ago

That would be possible but then telling the difference between i.e drivers/orogen/iodrivers_base and drivers/iodrivers_base would be a problem.

Thanks for the answer. That is an issue indeed. I don't have orogen packages on my package set at the moment so I didn't realize this.

Actually, there's a workaround you can use until the fix lands: use the full path to the folder you want to search in. That is, instead of ./base/types search in /home/dbcesar/dev/flat_fish/base/types :P

Hahaha. Right now I'm just renaming the folders myself as I don't add packages very often. It's fine until we have the fix.

doudou commented 3 years ago

Works now (vscode 1.59)