rock-simulation / pybob

Python build scripts
4 stars 7 forks source link

pybob.yml is corupt #14

Closed bpoppinga closed 3 years ago

bpoppinga commented 6 years ago

autoprojEnv: false buildconfAddress: https://github.com/rock-learning/bolero_buildconf.git buildconfBranch: '' defBuildType: debug devDir: ECHO is on. pyScriptDir: ECHO is on./pybob rockFlavor: master

AlexanderFabisch commented 6 years ago

...only on Windows (10?), of course.

AlexanderFabisch commented 6 years ago

This is most likely an issue with BOLeRo's installation script:

DEV_DIR="$( cd "$( dirname "$0" )" && pwd )" # what is the output?

if [ -f /mingw64.exe ]; then  # should be true on windows, can you verify this?
  DEV_DIR="$(cmd //c echo $DEV_DIR)"  # what is the output?
fi
...

# create default config for bolero
...
echo "devDir: ${DEV_DIR}" >> pybob.yml
echo "pyScriptDir: ${DEV_DIR}/pybob" >> pybob.yml
AlexanderFabisch commented 6 years ago

@malter The installation instructions for MARS seem to work on Windows 10. The difference is that pybob.yml is generated by pybob in this case. Why did we write the pybob.yml in the bootstrap script of bolero? Can I change it?

AlexanderFabisch commented 6 years ago

@bpoppinga Can you say which packages are missing?

malter commented 6 years ago

We write the pybob.yml because we know which buildconf to pull and the user doesn't have to enter the git address. I just tested the bootstrap script on Windows 10 with msys2 and it worked fine. What is the system configuration where the script fails?

AlexanderFabisch commented 6 years ago

But we could just run

./pybob.py buildconf path="https://github.com/rock-learning/bolero_buildconf.git"

right? Is there any drawback?

malter commented 6 years ago

We could do that, but then we would need the user interaction asking for the path, the default branches, and the buildconf branch. The default user doesn't have to know about that. If the user is more experienced and want to change the settings he doesn't need the bootstrap script and can install bolero directly with pybob or autoproj, having all the options.

malter commented 6 years ago

I still have no idea what went wrong here: devDir: ECHO is on. What shell was used? It looks like the following line went wrong: DEV_DIR="$( cd "$( dirname "$0" )" && pwd )" # what is the output? Maybe the script was executed with sh bootstrap_bolero.sh instead of bash ... or directly ./bootstrap_bolero.sh?

malter commented 3 years ago

Error could not be reproduced