search

rock-simulation / pybob

Python build scripts
5 stars 7 forks source link

use distro module for ubuntu version check #27

Closed maotto closed 3 years ago

maotto commented 3 years ago

As discussed in the commit comments, platform.version has inconsistent output (on two 18.04 kubuntu machines, I have no ~ in the output). The distro module is dedicated for an ubuntu version check. It is an added dependency yet to be documented (apt or pip?). However one can also just export QT5_UBUNTU=True or False to avoid installing distro.

maotto commented 3 years ago

for the installation instructions, I'd change it to sudo apt install git python3-yaml python3-distro
is that fine or do you want to keep the python2-variant?

AlexanderFabisch commented 3 years ago

I think this behavior and the environment variables should be documented somewhere

maotto commented 3 years ago

I've added it with apt, keeping the python2 variant.
I'll also update the bootstrap script in bolero - but same question, apt-get, apt or pip? As a conda user, I'd suggest pip.

AlexanderFabisch commented 3 years ago

I'll also update the bootstrap script in bolero - but same question, apt-get, apt or pip? As a conda user, I'd suggest pip.

Conda is a special case in my opinion. I'd rather manage this as another option.

AlexanderFabisch commented 3 years ago

@malter Did you have the chance to take a look? I would like to merge this as soon as possible since the installation on Ubuntu 20.10 currently does not work.