rockandrollwithemberjs / rarwe-issues

Errata and updates for the Rock and Roll with Ember.js book
https://rockandrollwithemberjs.com
43 stars 4 forks source link

Octane edition: use yarn instead of npm to install fontawesome #469

Closed belgoros closed 4 years ago

belgoros commented 4 years ago

On page 63, you used npm to install fontawesome dependencies:

npm install -D @fortawesome/free-regular-svg-icons @fortawesome/free-solid-svg-icons

I wonder why to use npm instead of yarn if we used it when creating the app in the very beginning. It creates another package-lock.json. Is it done intentionally? I used the following yarn command and it works the same:

yarn add -D @fortawesome/free-regular-svg-icons @fortawesome/free-solid-svg-icons
balinterdi commented 4 years ago

Thanks, great catch.

The problem, I now realize, is that we use --yarn when creating the app which shouldn't be there.

The book should use npm throughout as yarn is only recommended (and I'm using it "behind the scenes").