Closed GradedJestRisk closed 4 years ago
@GradedJestRisk Thank you, good spot.
By the way, it's quite useful when the reader want to replace its own (non-working) file version with the book's one, and his repository name doesn't match rarwe
. Are you okay with readers sharing their own code ? It's never mentioned in the book.
As access to the (private) repo is a paid add-on, I'd feel somewhat uneasy about my readers sharing their code. You make a good point about possibly different repo names, though we do start all with "ember new rarwe", unless I'm mistaken, so unless someone deviates from the beaten path, rarwe
should be the top-level module name.
I've turned the repository as private. Why not telling about it when allowing access to source code ?
@GradedJestRisk Thanks. You're totally right, I will.
There's another import in Chapter 7 songs controller
import { Song } from 'rarwe/routes/bands';
Can be replaced by
import { Song } from '../../../routes/bands';
But the actual code is
import config from 'rarwe/config/environment';
I suggestimport config from './config/environment';