search

rockandska / fzf-obc

fzf over bash complete
50 stars 6 forks source link

Error message on macOS #19

Closed gene-pavlovsky closed 4 years ago

gene-pavlovsky commented 4 years ago

I've installed this per the instructions, but attempting to use tab completion results in this error being printed: bash: /proc/cpuinfo: No such file or directory

There is no /proc on macOS.

The completion itself seems to be working, although with the annoying error message on every attempt to use it, I didn't do any extensive testing.

rockandska commented 4 years ago

Sorry, didn't had the time to test on macos but see clearly where it occurs and will push a patch before the end of the day if i can.

Thanks to have take the time to test it

rockandska commented 4 years ago

Could you checkout the branch fix/sort_parallel_macosx_error and let me know if it is ok now before merging it please ?

Regards,

gene-pavlovsky commented 4 years ago

Great, thank you. I will test it when you have a patch available. I'm also wondering if there would be some more undetected issues caused by macOS. While writing some bash scripts on macOS, I've found out that some standard commands provided by macOS have BSD-style options, different from their GNU counterparts which are more familiar to me from my previous Linux experience. When using an interactive shell I mostly avoid dealing with this, by using GNU versions of everything installed via homebrew package manager, but any shell scripts running would use the built-in tools from macOS. I don't know if fzf-obc involves running any shell scripts, perhaps it just adds completion functions to the running shell, in which case it should probably be ok provided that the GNU versions of tools are first in PATH (in my case they are).

gene-pavlovsky commented 4 years ago

Tested your branch, no more errors. Thanks for that fix. As for how it works with gradle, I've posted a comment in the original issue in the fzf repo.

rockandska commented 4 years ago

thanks for the test i will merge it and release a patch version soon.

For you answer on fzf original issue, post your concerns about zfz-obc in a new issue here to not pollute the fzf issue itself :smile: And add some reproducible example and will take a look if i could do something if it is not a pain ^^

Thanks