search

rockcarver / frodo-cli

A CLI to manage ForgeRock platform deployments supporting Identity Cloud tenants, ForgeOps deployments, and classic deployments.
MIT License
17 stars 14 forks source link

Add More Tests #313

Closed phalestrivir closed 8 months ago

phalestrivir commented 8 months ago

This PR adds some more tests to the CLI that were missing, and fixes some bugs that were found while creating them. There are a couple of tests that are currently being skipped: some delete tests do not have mocks for the -a --all option yet (since this involves deleting a lot of data) and for the esv-secret-create op there is currently no way of creating secrets encoded with pem or base64hmac, so these tests are skipped for now. There are no changes to the frodo-lib for this PR.

vscheuber commented 8 months ago

@phalestrivir I merged the first two PRs in lib and cli, would you be able to rebase and update this PR?

phalestrivir commented 8 months ago

@phalestrivir I merged the first two PRs in lib and cli, would you be able to rebase and update this PR?

@vscheuber Yes, I can rebase and update it, although I won't be able to get to it until tomorrow (Friday) afternoon. I'll let you know once it's updated and ready to go.

phalestrivir commented 8 months ago

@vscheuber I just rebased this PR, so it should all be good to go.