Camera images are green-ish with rkisp10

[teseo-sw]

I'm using an OV13850 sensor with rkisp10 framework. The image colors are biased towards a green-ish tone and more generally the colors seem not to be accurately reproduced.

I'm confident that the sensor's registers configuration and image conversion process on my side are correct. The same exact setup under Android produces correct images so there has to be a problem with rockchip's ISP driver.

Steps to reproduce:

$ v4l2-ctl --set-fmt-video=width=2112,height=1568,pixelformat=NV12 --stream-mmap --stream-count=1 -d /dev/video2 --stream-to=/tmp/image.nv12

Resulting image (captured from latest Linux): Expected image (captured from Android):

[teseo-sw]

Any hints anyone? @rkhuangtao @rkchrome

[teseo-sw]

Is this issue-tracker maintained? Who should I contact to get ISP/camera support?

[rkhuangtao]

You can contact ov13850 author, william.hu at rock-chips.com. Try send email. The best way is report bug through https://redmine.rockchip.com.cn/.

[teseo-sw]

Thank you so much, I'll try to contact him.

[DecksLabs]

@teseo-sw Any success? I managed to enable isp1 with this camera, but still I get green images :(

[teseo-sw]

You will need camera_engine_cifisp or camera_engine_rkisp along with an IQ calibration file suited for your sensor. We have one for OV13850 R1A which produces good colors:

[DecksLabs]

@teseo-sw Thank you! I tried to avoid it as much as possible as the camera_engine_rkisp contains loads of binary libs and generally seems to be pain to build :(

[teseo-sw]

Yes, it is a pain to build and contains binary only stuff but AFAIK it's the only way to get good images out of camera pipeline.

[Caesar-github]

To be honest, the refer document found on https://github.com/rockchip-linux/docs/blob/master/Linux%20reference%20documents/Camera/Rockchip_Developer_Guide_Linux_Camera_EN.pdf

Indeed, the camera_engine_cifisp or camera_engine_rkisp was used for rkis10 or rkisp1. We have used the rkisp1 with camera_engine_rkisp on linux platform by default.

[DecksLabs]

@teseo-sw @Caesar-github Although I built camera_engine_rkisp and I'm able to take pictures using it, it still produce somewhat greenish pictures. I got ov13850 cam module and imx219. For the imx219 don't have required calibration iq files.

Any tips here? Which plugin for gstreamer to use, which kernel version? I'm a bit lost since I think I tried pretty much everything that is available on rockchip github.

[teseo-sw]

FWIW I use latest develop-4.4 and cifisp_demo to capture images. I feel you pain, I tried pretty much everything myself. The only thing I'm sure about is that you'll need proper IQ calib for you specific sensors in order to get acceptable results.

[DecksLabs]

@teseo-sw Oh, so you actually used camera_engine_cifisp not rkisp one, right? That might be game changer :) Another question, if I might ask. I also use ov13850 module. Did you use calibration file or some other? If other, then how can you create one, it's kinda hard to get any data on the topic.

[teseo-sw]

I succesfully used OV13850 R1A with the attached calibration file. I do not know how to generate them, I asked our chip seller to cooperate with Rockchip in order to get a working IQ file for our specific OV13850 R2A sensor. We are still waiting. OV13850_V0.1.7.txt

[rothn]

I think it might have something to do with the default initialization in the rkisp1 driver. The function that initializes streams, rkisp1_params_configure(), sets defaults for white balance and exposure control, but not lens shade control (LSC). It's possible that we need to initialize this to a more sensible default to avoid the green color.