search

rockchip-linux / kernel

BSP kernel source
Other
944 stars 1.1k forks source link

Missing PHY driver for USB 3 in mainline #83

Open RobinMcCorkell opened 6 years ago

RobinMcCorkell commented 6 years ago

I'm not sure if this is the right place to report a potential issue with the upstreaming effort, but here goes.

The mainline kernel has support for USB 2, but is missing USB 3 since drivers/phy/rockchip/phy-rockchip-inno-usb3.c exists only here and not in mainline. Since the other PHY drivers exist in mainline, this seems like an inconsistency to me, perhaps something has been missed?

The mainline kernel has a different device tree, see the discussion below.

At the very least, the status matrix states that USB for the RK3328 is SUPPORT, while it should be INCOMPLETE due to this missing USB 3 support.

ShapeShifter499 commented 6 years ago

This issue is still a problem with kernel 4.18-rc4 It's missing in the official mainline kernel. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/rockchip?h=v4.18-rc4

ayufan commented 6 years ago

My mainline kernel does support USB3: https://github.com/ayufan-rock64/linux-mainline-kernel/ :)

ShapeShifter499 commented 6 years ago

@ayufan I'd need to convince Arch Linux ARM to make use of your kernel instead of mainline. Not sure who I should contact about that. Currently Arch Linux ARM claims support for Rock64 but doesn't mention anything on their wiki about USB 3.0 support.

ayufan commented 6 years ago

It is about missing PHY nodes for Rock64: https://github.com/ayufan-rock64/linux-mainline-kernel/commit/84802c45a7cff42215869de40a2632db5f4a3be6 and something like this: https://github.com/ayufan-rock64/linux-mainline-kernel/commit/4109a410cdcfbd0c716cb765c582261f2197a73b.

Pretty fair you can add that on top of existing dtbs.

ShapeShifter499 commented 6 years ago

@ayufan so this file isn't required? drivers/phy/rockchip/phy-rockchip-inno-usb3.c

ayufan commented 6 years ago

No. Just dts change.

ShapeShifter499 commented 6 years ago

@ayufan Thanks, people are working now to get the required DTS changes for the Rock64 into mainline. https://archlinuxarm.org/forum/viewtopic.php?p=58866#p58866

Other rockchip boards maybe still affected by the original issue above of drivers/phy/rockchip/phy-rockchip-inno-usb3.c missing in mainline.

vitalif commented 5 years ago

@ayufan it seems USB3 does not work in your 4.20 mainline kernel

ayufan commented 5 years ago

Thanks. I need help

On Mon, 25 Feb 2019 at 18:05, Vitaliy Filippov notifications@github.com wrote:

@ayufan https://github.com/ayufan it seems USB3 does not work in your 4.20 mainline kernel

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rockchip-linux/kernel/issues/83#issuecomment-467092590, or mute the thread https://github.com/notifications/unsubscribe-auth/ACTpQTYo4jECChfpBYk4qehbpQSAcj75ks5vRBfIgaJpZM4TFsew .