rockchip-linux / mpp

Media Process Platform (MPP) module
466 stars 155 forks source link

RK3588 is it possible to support tone mapping Dolby Vision video file? #607

Open jwsky opened 1 month ago

jwsky commented 1 month ago

i'm using orange pi 5 plus,rk3588 ,i've already installed my lib to the correct version v1.9-1-2d267b0 and such HWA settings by the official tutorial,and the hwa works,but the tone mapping does not work.it's a dovi movie file ,the color seems a little like to purple and green.

i'm testthe OS: 1,Official Images of ubuntu focal ,downloaded from the official website. not work 2,ubuntu 24 from https://github.com/Joshua-Riek/ubuntu-rockchip . not work

uname -a Linux ubuntu 6.1.0-1013-rockchip https://github.com/jellyfin/jellyfin-ffmpeg/pull/13-Ubuntu SMP Thu May 9 21:20:56 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux

log11.txt clinfo_output.txt

video file info: Video Title: 4K HEVC HDR Codec: HEVC AVC: No Profile: Main 10 Level: 150 Resolution: 3840x2160 Aspect ratio: 16:9 Anamorphic: No Interlaced: No Framerate: 23.976025 Bitrate: 24998 kbps Bit depth: 10 bit Video range: HDR Video range type: DOVI DV title: DV Profile 5 DV version major: 1 DV version minor: 0 DV profile: 5 DV level: 6 DV rpu preset flag: 1 DV el preset flag: 0 DV bl preset flag: 1 DV bl signal compatibility id: 0 Pixel format: yuv420p10le Ref frames: 1

jwsky commented 1 month ago

more info added here

HeyMeco commented 1 hour ago @nyanmisaka Dolby Vision Tonemapping in general isn't an issue. In this case it's the DoVi Profile 5 based source that's causing problems. It uses a proprietary color space:

As defined in SMPTE ST 2128:2023, IPT-PQ-C2, previously a Dolby Vision proprietary color space, is similar to BT.2100 ICtCp, where I is similar to I, P similar to Cp, and T similar to Ct. As of the date of this specification, the MPEG Joint Video Experts Team (JVET) working group has standardized the code point for this previously proprietary color space, also known as IPT-PQ-C2, using code point 15. @jwsky It would make more sense to use dovi_tool to convert the source file from 5 to 8.1 for maximum compatibility.

@nyanmisaka Member nyanmisaka commented 1 hour ago Jellyfin actually supports DV P5 to SDR tone-mapping on platforms other than Rockchip. Just because the metadata cannot be properly imported from MPP into FFmpeg.

mo123 commented 1 month ago

RK3588 has no hardware support for Dolby Vision.

nyanmisaka commented 1 month ago

RK3588 has no hardware support for Dolby Vision.

That's another story, and it has no impact on this issue. I just need to get dynamic metadata from the decoder that can be used by FFmpeg, and let the GPU renderer does the rest.