rockchip-linux / rkdeveloptool

GNU General Public License v2.0
175 stars 108 forks source link

Fix string formatting problem #85

Open MaksimKarpovich opened 1 year ago

MaksimKarpovich commented 1 year ago

solve string formatting problem (#80) with error:

make[1]: Entrando no diretório '/home/${USER}/rkdeveloptool' g++ -DHAVE_CONFIG_H -I. -I./cfg -Wall -Werror -Wextra -Wreturn-type -fno-strict-aliasing -D_FILE_OFFSET_BITS=64 -D_LARGE_FILE -I/usr/include/libusb-1.0 -g -O2 -MT main.o -MD -MP -MF .deps/main.Tpo -c -o main.o main.cpp main.cpp: In function ‘bool _Z9mergeBootv.part.0()’: main.cpp:1493:43: error: ‘%s’ directive output may be truncated writing up to 557 bytes into a region of size 5 [-Werror=format-truncation=] 1493 | snprintf(buffer, sizeof(buffer), "%s", chip); | ^~ ...... 1534 | chipType = convertChipType(chip + 2); | ~~~~~ In file included from /usr/include/stdio.h:894, from DefineHeader.h:3, from main.cpp:11: /usr/include/x86_64-linux-gnu/bits/stdio2.h:71:35: note: ‘builtin_snprintf’ output between 1 and 558 bytes into a destination of size 5 71 | return _builtinsnprintf_chk (s, n, USE_FORTIFY_LEVEL - 1, | ~~~~~^~~~~~~~~~~ 72 | glibc_objsize (s), fmt, | ~~~~~~~~~ 73 | __va_arg_pack ()); | ~~~~~ cc1plus: all warnings being treated as errors make[1]: [Makefile:491: main.o] Erro 1 make[1]: Saindo do diretório '/home/yan/rkdeveloptool' make: [Makefile:511: all-recursive] Erro 1

jdchmiel commented 1 year ago

thankyou for this! not a C / C++ dev so this saved me time!

renich commented 1 year ago

I can confirm this fix works on Fedora 38 x86_64.

o-murphy commented 1 year ago

+1

grasmanek94 commented 11 months ago

makes it compile here too.

0xStuart commented 7 months ago

Thanks you, worked for me.

timblechmann commented 2 months ago

could this patch potentially be merged? it is listed in the radxa's official build instructions: https://docs.radxa.com/en/compute-module/cm5/radxa-os/low-level-dev/rkdeveloptool?host-os=debian