search

rockdaboot / wget2

The successor of GNU Wget. Contributions preferred at https://gitlab.com/gnuwget/wget2. But accepted here as well 😍
GNU Lesser General Public License v3.0
549 stars 75 forks source link

OCSP requests bodies are printed in debug output despite being binary #344

Closed tobiasb-ms closed 1 week ago

tobiasb-ms commented 2 weeks ago

When the --ocsp and --debug are specified with an openssl tls provider, the debug_skip_body field is not set on the request, which causes the binary body of the request to printed to debug output. This can cause very interesting things with the command prompt, depending on the binary data being spewed out.

With gnutls as the tls provider, the field is set properly. But with openssl, it isn't.

I've created a draft pull request #345 as a potential fix for this.

rockdaboot commented 1 week ago

Fixed by #345