remove underscore from sql-bricks codebase

rockdai / sql-bricks

Transparent, Schemaless SQL Generation

http://csnw.github.io/sql-bricks

MIT License

213 stars 25 forks source link

remove underscore from sql-bricks codebase #127

Closed pgarrison closed 3 years ago

pgarrison commented 3 years ago

Removing underscore is now of high importance since the outdated underscore version in use now has a critical vulnerability

I addressed some issues from the prior PR #112, building on @schuttsm's code

prust commented 3 years ago

@pgarrison: Thank you! This looks good to me (after a cursory skim) and it looks like the tests pass, so that's a good sign. I'm going to go ahead & merge, but we may want to publish this as a pre-release version or ask a few people who are using the library to test it out in their projects to give it more exercise.