Add _extension() helper

prust commented 10 years ago

This is an iteration on @Suor's #55:

Switched from environment variables to command-line args (the way to set env vars in Windows is different) fcb56db
Fixed browser support (is_common_js or window.process &&; checking process && throws an error) fcb56db
Merged in browser test updates from master b90d9e1 (removed references to other dialects)
Switched from construct() to applyNew() (both are answers to http://stackoverflow.com/q/1606797/194758, construct() is most popular, but I prefer the second most popular with ctor.bind.apply() -- it's a little harder to understand, but it seems cleaner to me) 9ce29e9
Re-ordered extensions functions with top-level _extension() at the top 9ce29e9
Switched from hasOwnProperty() to _.keys(), which does hasOwnProperty() check if necessary and handles IE<9 edge-case 9ce29e9, f595b88

prust commented 10 years ago

@Suor: I made some minor tweaks to your pull request, mostly code style, but also switched to an alternative method of using apply() with new.

Please let me know if this works for you (I did test it with an empty extension and applied the applyNew() change to sql-bricks-postgres and the tests there passed, but I haven't run the sql-bricks-postgres tests with all these changes)

Suor commented 10 years ago

I found a bug (my own) and fixed it in https://github.com/CSNW/sql-bricks/pull/57.

rockdai / sql-bricks

Add _extension() helper #56