rockdai / sql-bricks

Transparent, Schemaless SQL Generation
http://csnw.github.io/sql-bricks
MIT License
213 stars 25 forks source link

Extension helper with fixed clauses shielding #57

Closed Suor closed 10 years ago

Suor commented 10 years ago

I detected that clauses weren't copied properly in _extension(). This was cause of using instanceof check where really "subclass of" check should be.

I goed to explicit naming what to subclass though, since there are also aliases insertInto and deleteFrom, which better be still aliases, not distinct subclasses.

Suor commented 10 years ago

I also added a test for _extension() shielding.

prust commented 10 years ago

Looks good, @Suor, thanks! Merging.

prust commented 10 years ago

@Suor: I bumped the minor version (to 1.1.0), since these changes affect people using SQLBricks via an extension library (postgresql-bricks/sqlite-bricks), though I doubt there are very many people doing that right now.