search

rockdai / sql-bricks

Transparent, Schemaless SQL Generation
http://csnw.github.io/sql-bricks
MIT License
213 stars 25 forks source link

inheritance (private methods as sql._ use as is for overriding) #99

Closed cybermerlin closed 6 years ago

cybermerlin commented 7 years ago

for override need use functions as methods (sql._*())

prust commented 6 years ago

@cybermerlin: sorry for the delay responding to this pull request, the diff is so large (every line is changed) that I finally had to clone your repo and use a comparison tool (Beyond Compare) to see what exactly you had changed (and to ignore the formatting/whitespace/line-break changes).

That said, I think the changes here will be overtaken by the proposed changes in 3.0. If there was a particular issue that you needed to work around or feature you needed, please let me know what that was so that I can be sure that it is covered in 3.0.

The majority of changes in this pull request are stylistic (and are not consistent with the preexisting code style), so I'm going to go ahead & close it.