search

rockdoc / cdlparser

A python module for parsing files encoded in netCDF's common data form language (CDL)
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

added support python3 and fix some tests for Fillvalues and numpy mask #20

Closed ocehugo closed 5 years ago

ocehugo commented 8 years ago

Hi,

thanks for the effort. I have implemented python3 support and fix some things related to the tests that were failing in new versions of netCDF4 and py3 ( particularly the automatic masking). Now the package works for both py2(>2.6) and py3.

I'm also interested in NETCDF4 cdl syntax support #5 (groups not quite yet since my files do not use it). I saw #19, but I have no idea how to deal with this parsers/lex things. Would you like to do some tutoring for me to implement this? i don't have much time but in the long term I would like to store cdl instead of raw netcdfs as variable 'databases'.

Don't know if you plan to rewrite or keep this repo rolling for the future, nonetheless let me know what the future plans are.

I will also push someday more tests from my local poor man cdl reader that will improve the testing ;)

Cheers

PS: I think I run the autopep8 in the code so it's hard to look at the diffs, sorry about that.

rockdoc commented 8 years ago

Hi Hugo,

Thanks. As you say in your PS line above, you have pep8-ified your code so I can't see what the significant diffs are. If you want to resubmit just the code for the new unit tests, honouring the original coding style, then I'd be happy to take another look. But don't feel obliged!

I have no immediate plans to work on this code as I have other more pressing commitments right now. Adding support for netCDF4 syntax would, I suspect, be a significant undertaking, and to be honest I'm not convinced the demand is out there to justify the effort.

Regards,

rockdoc

ocehugo commented 8 years ago

Hello, Yeap, those automatic things that are supposed to make your life better. I believe it's since from the start so my edits were done with it since the beginning (it's run autopep/flake/etc on write). I'll leave as is since i dont have time to unpep.

You are right, with ncml out there it's hard to keep using cdl for storing nc metadata (it's the future i suppose). I just realized that it's too easy to read xml...I should write a ncmlreader/ncmlgen :P

rockdoc commented 5 years ago

Closing this PR owing to the pep8 issue mentioned in my earlier comment.