search

rocker-org / rocker-versioned

Run current & prior versions of R using docker
https://hub.docker.com/r/rocker/r-ver
GNU General Public License v2.0
297 stars 169 forks source link

Added pdfcrop to rocker/verse #147

Closed riccardoporreca closed 5 years ago

riccardoporreca commented 5 years ago

Added pdfcrop to rocker/verse to support the default fig_crop: true of R Markdown with TinyTeX. Updated both verse/Dockerfile and verse/devel/Dockerfile https://github.com/rocker-org/rocker-versioned/issues/146#issuecomment-492916714.

Note that installed LaTeX packages are now listed alphabetically, to allow easier maintenance and possible comparison to the packages part of the default TinyTeX installation (see FAQ). One may consider removing them from the list .

No pdfcrop in the current rocker/verse:latest:

docker pull rocker/verse:latest
docker run --rm rocker/verse:latest which pdfcrop
## latest: Pulling from rocker/verse
## Digest: sha256:4014cadbc8656390c5b77f9f5fedaf669b0411d696b18cd0c90dab5f9cb9a7b8
## Status: Image is up to date for rocker/verse:latest

pdfcrop available in the branch on the forked repo:

CHECKOUT_DIR=/tmp/rocker-versioned
git clone -q -b verse-pdfcrop https://github.com/riccardoporreca/rocker-versioned.git $CHECKOUT_DIR
docker build -q -t rocker/verse:pdfcrop $CHECKOUT_DIR/verse
docker run --rm rocker/verse:pdfcrop which pdfcrop
rm -rf $CHECKOUT_DIR
## sha256:13c83dd4172cf3ad3b4ecb803f45acac8b8d7c18f21892b09c332a8b4689bb14
## /usr/local/bin/pdfcrop
riccardoporreca commented 5 years ago

@cboettig, let me know if I shall rebase the branch in my fork given a few commits have been pushed to rocker-org:master in the meantime.

cboettig commented 5 years ago

@riccardoporreca thanks for the ping -- diff looks fine actually so I think we're all good on this one. Thanks for again for the PR. here goes :ship: