search

rocker-org / rocker-versioned

Run current & prior versions of R using docker
https://hub.docker.com/r/rocker/r-ver
GNU General Public License v2.0
297 stars 169 forks source link

Added svn to Rstudio image #158

Closed AnotherStranger closed 5 years ago

AnotherStranger commented 5 years ago

Hello, i was missing svn support and added it to the rstudio Dockerfile. I thought that this small change could be useful for others, too.

I'm not very experienced with docker and the like. If i made any mistake I'm more than happy to correct them.

Thank you.

eddelbuettel commented 5 years ago

The PR is "technically correct" (well, the deb packages were alphabetically sorted so the addition belonged on line 27, not 19) but the bigger issue is if we really want to add other programs to the default image for everybody,

I understand you need svn. But we cannot accomodate each of these request or we'd converge to sumo images containing "everything". svn is arguably on the way out so and not used as much as it was used -- may we suggest you derive from our containers and create a local variant?

AnotherStranger commented 5 years ago

Of course. This "change" is trivial for anyone. I just thought it'd be a good idea since RStudio offers SVN integration. However, I could just derive from Your images and add SVN myself. Thanks for your reply.

And by the way these images are great! Keep up the good work.