rocker-org / rocker-versioned

Run current & prior versions of R using docker
https://hub.docker.com/r/rocker/r-ver
GNU General Public License v2.0
297 stars 169 forks source link

Creation of a versioned "official docker image" #168

Closed pat-s closed 5 years ago

pat-s commented 5 years ago

Currently there is one "official docker image" for R based on rocker/r-base.

I was wondering if there already have been thoughts on applying for a versioned one based on rocker/r-ver?

Instructions for applying for an official image can be found here.

Use case

I am currently trying to add official support for the R language on Circle CI. There, images need to be based on a "official" docker image. This means currently no version support is possible. Hence the idea of a versioned "official docker image" for R.

eddelbuettel commented 5 years ago

There is. Tags.

edd@rob:~$ docker images | grep r-base             # snapshot on my workhorse box
r-base                       3.6.1               4e55790c88ae        3 months ago        642MB
r-base                       latest              4e55790c88ae        3 months ago        642MB
rocker/r-base                latest              b39219378c26        3 months ago        644MB
r-base                       3.6.0               6dfc0dec6d66        5 months ago        662MB
r-base                       3.5.3               62c848eeb175        7 months ago        649MB
r-base                       3.5.2               578644a0540c        9 months ago        650MB
r-base                       3.5.1               93ca38345db2        15 months ago       678MB
r-base                       3.5.0               fb43e8fe1667        16 months ago       698MB
r-base                       3.4.3               d1e1c25485af        19 months ago       670MB
r-base                       3.4.2               02d3b7e00020        23 months ago       651MB
r-base                       3.4.0               5a6c58403310        2 years ago         656MB
r-base                       3.3.3               88436550cddc        2 years ago         635MB
r-base                       3.3.1               7ba1baf9d8bb        3 years ago         657MB
edd@rob:~$

Good enough?

eddelbuettel commented 5 years ago

After all we are doing this for R, and R and CRAN really 'live at @HEAD' (to borrow that phrase). Current R-release matter, R-devel matters (and we have both in Rocker).

Everything else can be used in Circle CI to everybody's heart's contents but it really does not have to be an official image, does it?

@tianon @yosifkit have been approving my PR for the 'current at the time of release' r-base. I don't think we need to go beyond this especially as we already have the entire r-versioned stack for R in this Rocker Project thanks to @cboettig .

But it is really the call of @tianon @yosifkit. There is already a lot in the official-images repo but I no good feeling if beyond the one 'wide' dimentions of languages / frameworks / tools there is also a 'vertical' one for time...

pat-s commented 5 years ago

After reading Circle CIs policy again and exploring the tags of the r-base image, I think everything is fine.

Using r-base as the base for the Circle-CI image will create all tags that come with the r-base image. Hence all versions supported by r-base will also be supported by the Circle image.

My goal is to have an image for R here. This would result in an instant startup when specifying circleci/r-base: rather than having to pull the rocker images on every build (as it is now). This saves both bandwith and time.

Thanks Dirk. I simply did not see the "tags" in the official docker image / was not aware of them previously (even though I used them, lol).

eddelbuettel commented 5 years ago

And by the way big thumbs up for getting "official" (public) images into CI toolchains. I have been doing a little under the radar for my Travis CI use as well -- being to reproduce exactly in multiple venues is key.