rocker-org / rocker-versioned

Run current & prior versions of R using docker
https://hub.docker.com/r/rocker/r-ver
GNU General Public License v2.0
297 stars 169 forks source link

Various changes in gdal compilation and structure #17

Closed rkrug closed 7 years ago

rkrug commented 7 years ago
cboettig commented 7 years ago

Cool, good idea.

Can you remove the build deps after compiling? Take a look at the r-ver Dockerfile for an example. You'll need to do it all in one layer (one RUN) for it to actually save space.

I think you've actually lost the MRAN definition, it is in etc/environment and doesn't persist between layers.

rkrug commented 7 years ago

I'm looking at it. Found where I lost MRAN - moved it to the end.

cboettig commented 7 years ago

Sorry, I might have worded that poorly (was writing from phone). -- you're setting MRAN as an environmental variable, but MRAN is already getting set automatically in /etc/environment. This lets the Makefile create versions for R 3.3.1, 3.3.2 etc that install R packages from MRAN snapshots of CRAN corresponding to when that version of R was last current; see the repo README.

By the way, is there a quick command to check what capabilities GDAL is compiled with? (e.g. the equivalent of R's capabilities()?

rkrug commented 7 years ago

I saw the definition and moved the removal of /etc/environment to the end - working now.

Yes - any gdal command with --formats should give you the capabilities- same with e.g. ogr2ogr --formats for the ogr (vector) drivers.

rkrug commented 7 years ago

Thanks @edzer - fixed it with the last commit.

rkrug commented 7 years ago

Thanks - I think now we can move to the next step - which additional software and packages.