rocker-org / rocker-versioned

Run current & prior versions of R using docker
https://hub.docker.com/r/rocker/r-ver
GNU General Public License v2.0
297 stars 169 forks source link

/etc/cont-init.d/add not found #219

Closed harveyche closed 3 years ago

harveyche commented 4 years ago

I am using a dockerfile and build from image rocker/tidyverse:3.6.3 and I want to enable shiny. I added this line to dockerfile: RUN export ADD=shiny && bash /etc/cont-init.d/add

When start docker build, here's the error message: bash: /etc/cont-init.d/add: No such file or directory

cboettig commented 4 years ago

thanks, I'll take a look. That should still work on the 3.6.3 image...

@noamross are we changing this mechanism in 4.0.0 image? I don't think the add_shiny.sh script is in the 4.0.0 rstudio recipe currently

odonovank commented 4 years ago

I had the same issue but switching to the latest version and using the code below in my own Dockerfile sorted it:

FROM rocker/rstudio:latest RUN /rocker_scripts/install_shiny_server.sh \

dunhampa commented 4 years ago

I ran into similar issue.

It was resolved when I changed

FROM rocker/geospatial

to

FROM rocker/geospatial:3.6.0

nielsaka commented 4 years ago

Similar here. Using rocker/rstudio:3.6.3 and -e ADD=shiny shiny is installed, for version 4.0.2 it is not.

hoegge commented 3 years ago

Isn't it time to fix this?

cboettig commented 3 years ago

@hoegge as noted above,

 RUN /rocker_scripts/install_shiny_server.sh

is the recommended way to add in shiny support on any rocker image. Unlike the previous mechanism, this should work across the rocker versioned stack, whether or not you also use RStudio. This is also the way to extend any image, e.g. other services (like binder) or package stacks (like the geospatial image stack) can also be added by rocker_scripts. We believe this approach is more transparent and general then the earlier implementation. feedback welcome.

skranz commented 3 years ago

Since I also stumbled over this issue, I just wanted to mention that the instructions on dockerhub here:

https://hub.docker.com/r/rocker/rstudio

still have the outdated command

RUN export ADD=shiny && bash /etc/cont-init.d/add

instead of the new command

RUN /rocker_scripts/install_shiny_server.sh
eitsupi commented 3 years ago

We need to refer to the rocker-org/rocker-versioned2 repository on GitHub, as described as a note on the rocker/rstudio page on DockerHub.

image

Related Issue: https://github.com/rocker-org/rocker-versioned2/issues/191

cboettig commented 3 years ago

Thanks, yeah the READMEs on DockerHub have become somewhat unsynced from the READMEs on GitHub. I've amended that Readme on DockerHub now!