search

rocker-org / rocker-versioned

Run current & prior versions of R using docker
https://hub.docker.com/r/rocker/r-ver
GNU General Public License v2.0
297 stars 169 forks source link

Add semantic version labels #43

Closed nuest closed 7 years ago

nuest commented 7 years ago

Fixes #42

cboettig commented 7 years ago

Thanks @nuest , let's give this a try!

Do we need to fiddle with anything on Docker Hub (or the cron job triggers) to activate this?

nuest commented 7 years ago

Thanks! I forget to suggest a squashed merge... apologies for the messy commits.

No, nothing else to.

The hooks should run on the next triggered build of the Dockerfiles in the x.y.z directories. Since the latest builds are based on separate Dockerfiles, which do not have hooks, and last non-push builds are 16 days old, we have to wait a bit for the tags to appear.

cboettig commented 7 years ago

Hey @nuest ,

Looks like, for some reason, the CRON jobs that used to trigger just latest and devel are now triggering the entire build stack, which we don't want to do. I think this is due to the post_hooks, but maybe not.

I've added your docker hub user to the rockerver team, which has admin access to the hub repos, in case you want to try and troubleshoot.

I can email you my cron table in case it's at fault.

cboettig commented 7 years ago

Ok, looks like I was missing some quotations in my POST data cron trigger that caused the full builds. Sorry about that. (had to recreate the cron job after some server issues and wasn't careful). Trying this again now. Thanks again for the PR.

nuest commented 7 years ago

No worries, saved by being busy. Apologies for not looking into this sooner. What's your next step: Wait for the CRON jobs to kick in again?

cboettig commented 7 years ago

Yups. I've already tickled a bunch of the builds, haven't checked if everything has been finished though. put check out: docker pull rocker/r-ver:3 or docker pull rocker/tidyverse:3.3