search

rocker-org / rocker-versioned

Run current & prior versions of R using docker
https://hub.docker.com/r/rocker/r-ver
GNU General Public License v2.0
297 stars 169 forks source link

Container environment in RStudio #74

Closed rstub closed 6 years ago

rstub commented 6 years ago

Currently if I set environment variables via docker run --environment ... these are not visible in RStudio. AFAIK one has to replace /bin/bash with /usr/bin/with-contenv bash in /etc/services.d/rstudio/run to change this. Anything speaking against such a change?

cboettig commented 6 years ago

@rstub Thanks, I believe you're correct: it would be better for us to use/usr/bin/with-contenv bash in https://github.com/rocker-org/rocker-versioned/blob/master/rstudio/Dockerfile#L67, like we do in userconf.sh. Would you care to send a PR for this?

rstub commented 6 years ago

I just tried to create a PR. However, I do not understand how changes to rstudio/Dockerfile are synced to rstudio/<version>/Dockerfile, since there is no sync target in rstudio/Makefile.

cboettig commented 6 years ago

Short answer is "manually."

Not all changes are backwards compatible with earlier versions; some edits need to be manually adjusted for differences between stretch and jessie, some shouldn't be backported at all, so I found it was better to drop the sync targets than accidentally sync incompatible changes.

This one seems to me like the kind of bug-fix that should be backported to all earlier versions; since I believe it corresponds with the originally expected behavior anyway. Thanks!