search

rocker-org / rocker-versioned

Run current & prior versions of R using docker
https://hub.docker.com/r/rocker/r-ver
GNU General Public License v2.0
297 stars 169 forks source link

Shiny should be included by default #86

Closed joerg closed 6 years ago

joerg commented 6 years ago

Hi, I have to work in an airgapped environment, meaning that my servers have no active internet connection. Thus running with "-e ADD=shiny" is not possible since that would require an active internet connection. Do you think it would be possible to provide shiny preinstalled in the image instead of installing it on the fly in the container? That would also make everything more reproducible. In the end, the only change required would be to run the add_shiny.sh in the Dockerfile ... What do you think? Any suggestions on this? Do you want a pull request for this?

eddelbuettel commented 6 years ago

Does this help?

https://github.com/rocker-org/shiny

"Crossing" shiny over all versioned containers is something which @cboettig declined once before IIRC as there is only so much we can do as volunteers..

joerg commented 6 years ago

I know this Image, yes, but the problem is, that it is not versioned. For a production deployment this would be quite suboptimal. I understand that adding shiny by default would be problematic in some ways. Maybe versioning shiny would be possilbe? I am not too familiar with R and its environment, but Docker is my topic so I can help here if you want...

eddelbuettel commented 6 years ago

Methinks the easiest would just be for you to take our versioned images, run ADD=shiny for a local container and deploy that locally.

joerg commented 6 years ago

Well, as I already explained that is not possible due to the lack of an active internet connection.

eddelbuettel commented 6 years ago

Let me be more explicit:

You obviously can get our unmodified containers to the air-gapped machine, you should be able to get a modified one there too. We do this as volunteers, and we cannot accomodate every change request that comes in. Sorry.

joerg commented 6 years ago

If it would be that easy I'd already done it some time ago. All we have is a proxy cache that lets us pull docker images. Nothing else is possible and will not be permitted by our local security. But I see that there is an unwillingness to include shiny by default and I have to accept that. Do you think version tagging the shiny image would be an option?

joerg commented 6 years ago

Ok, I've come to the conclusion that versioning shiny would be a lot better than including it here by default. Sorry for bugging you, but I will open a new ticket for shiny...