search

rocker-org / rocker-versioned2

Run current & prior versions of R using docker. rocker/r-ver, rocker/rstudio, rocker/shiny, rocker/tidyverse, and so on.
https://rocker-project.org
GNU General Public License v2.0
409 stars 173 forks source link

install_julia.sh doesn't install the latest version of Julia #763

Closed Hua-Zhou closed 6 months ago

Hua-Zhou commented 7 months ago

This potential bug doesn't affect pre-built images. It only affects users who want to call the script install_julia.sh to install the latest version of Julia in the Docker image.

If a user doesn't specify the environment variable JULIA_VERSION, the current script install_julia.sh will always install Julia v1.9.4, even though the latest stable version of Julia is 1.10.1 now.

Changing this line latest_version <- sort(versions[is_stable], decreasing = TRUE)[1] to latest_version <- as.character(sort(numeric_version(versions[is_stable]), decreasing = TRUE)[1]) should fix the issue.

eitsupi commented 7 months ago

Thanks for the report. Would you be interested in submitting a pull request?

I think this script should ideally be rewritten to use juliaup, but haven't worked on that because I was wondering if there is a user need.

Hua-Zhou commented 7 months ago

+1 for "juliaup"-ify the script. My use case: I teach courses in a biostatistics department in different languages: R, Python, and Julia. It'll be nice to have an image with the full JUPYTER (Julia+Python+R) stack. I used to build from the math-server-docker, but that's CentOS-based and the build process is unbearably long.