search

rocker-org / rocker-versioned2

Run current & prior versions of R using docker. rocker/r-ver, rocker/rstudio, rocker/shiny, rocker/tidyverse, and so on.
https://rocker-project.org
GNU General Public License v2.0
390 stars 163 forks source link

Ensure SIGTERM leads to graceful termination in rocker/binder #773

Closed consideRatio closed 3 months ago

consideRatio commented 3 months ago

Fixes #771, not by introducing tini, but by ensuring we don't let sh be the init process which in turn runs jupyter lab without propegating SIGTERM to it.

There may be a point to introduce tini or similar, but from the SIGTERM perspective, this does the trick as well.

This PR is modelled on for example https://github.com/rocker-org/rocker-versioned2/pull/740/files where I see that all Dockerfiles are updated along with a repsective .json file.

cboettig commented 3 months ago

@eitsupi thoughts on this?

consideRatio commented 3 months ago

I did a force push. I saw that I had updated .json files incorrectly to reflect the changes in the Dockerfiles (left /bin/sh -c in the .json representation still)

consideRatio commented 3 months ago

I've tested to startup the Dockerfile built just adjusting CMD as this PR does and it works fine, but I don't understand what I changed in the .json files.

eitsupi commented 3 months ago

I have confirmed that the JSON file has now been changed without any problems.

consideRatio commented 3 months ago

I don't have anything to say, but please merge if you are sure because I have no idea if this Dockerfile will work correctly.

@cboettig you hold the ball to get this merged - ok to go?

cboettig commented 3 months ago

thanks for the ping!