rocker-org / rocker-versioned2

Run current & prior versions of R using docker. rocker/r-ver, rocker/rstudio, rocker/shiny, rocker/tidyverse, and so on.
https://rocker-project.org
GNU General Public License v2.0
409 stars 173 forks source link

Repository structure overhaul #776

Open eitsupi opened 6 months ago

eitsupi commented 6 months ago

I will be working over the next few weeks on the repository overhaul that was discussed in several issues.

The current repository structure was originally designed to be updated manually, and I forced it to be changed to be updated automatically several years ago (#181), so it is not optimized for automatic updates. (Files that should be updated manually and files that are automatically generated are not completely separated.) And, because Dockerfile is generated from json and R scripts, it is not possible to generate complex Dockerfiles that incorporate multi-stage builds.

Therefore, rewrite the structure assuming automation as follows:

PoC can be found here. https://github.com/eitsupi/rocker-versioned-next

eitsupi commented 5 months ago

Sorry for the slow work. I have not given up on completing this this week and here is the work in progress. eitsupi/rocker-versioned-next#1

I am thinking of making the following changes:

cboettig commented 5 months ago

All for removing latest-daily. why exclude rocker/binder though?

eitsupi commented 5 months ago

why exclude rocker/binder though?

As I wrote here, I think the current build strategy is not ideal for rocker/binder. https://github.com/rocker-org/rocker-versioned2/issues/614#issuecomment-2028107573

cboettig commented 5 months ago

:100: right, sorry I got confused between the two threads. I've wondered if we should be pinning python versions in rocker/binder, but the rationale there given the recent security patch etc makes sense, and easier to do this with the build strategy you suggest in https://github.com/rocker-org/rocker-versioned2/issues/614#issuecomment-2028107573 !