rocker-org / rocker

R configurations for Docker
https://rocker-project.org
GNU General Public License v2.0
1.45k stars 273 forks source link

add fedora-based r-bspm images #444

Closed Enchufa2 closed 3 years ago

Enchufa2 commented 3 years ago

For Fedora 33 (current stable release) and rawhide, under the r-bspm directory, as discussed. I tried to follow the other images' philosophy (docker user, availability of install.r and remotes).

eddelbuettel commented 3 years ago

It adds another layer to the directory structure. Currently we just have r-bspm/${FLAVOUR}/Dockerfile. And I like that better.

Maybe fc33 and fcrawhide or something?

Enchufa2 commented 3 years ago

Apologies, it still requires an adjustment.

eddelbuettel commented 3 years ago

What was the change? They look good to me... (and we simply could add one or more softlinks -- install2.r, originally written by @cboettig for our use in Dockerfiles, it pretty handy too -- but install.r will do for demo purposes). Nice and tidy.

Does this need the 'work in progress' tag?

Enchufa2 commented 3 years ago

Ready now. I forgot to set repos for the fallback and the path to the user's library was wrong.

eddelbuettel commented 3 years ago

What's a better / more common tag for the container then? 'fc33' ? 'f33' ? '33' ?

I plan to make the second one just 'rawhide'.

Enchufa2 commented 3 years ago

Better f33; rawhide is fine for the other.

eddelbuettel commented 3 years ago

Will do.

eddelbuettel commented 3 years ago

They are there now: https://hub.docker.com/r/rocker/r-bspm/tags?page=1&ordering=last_updated

Enchufa2 commented 3 years ago

Great, thanks!