rockerhieu / emojicon

A library to show emoji in TextView, EditText (like WhatsApp) for Android
Apache License 2.0
3.61k stars 818 forks source link

using DialogFragment #22

Open ankushsachdeva opened 10 years ago

ankushsachdeva commented 10 years ago

Can we have the EmojiconsFragment class in the form of a dialog(using DialogFragment) so that we can easily replace this fragment in place of the soft keyboard. This is how whatsapp and other messaging apps smoothly toggle between qwerty keyboard and emoticons

ankushsachdeva commented 10 years ago

incase someone wishes to do that, make EmojiconsFragment class extend DialogFragment and for the first argument while initializing EmojisPagerAdapter replace getSupportFragmentManger() with getChildFragmentManager()

rockerhieu commented 9 years ago

I will work on this feature soon.

ankushsachdeva commented 9 years ago

Since, this issue did not gain much attention, I made a new project based on this library that does the job. You can find it here. https://github.com/ankushsachdeva/emojicon

daniele-athome commented 9 years ago

@rockerhieu are you sure we can obtain the same results as a PopupWindow and the same behaviour? I was going in the same direction of #39 (a bit less invasive maybe), but I will also try with a DialogFragment to see what happens.

funcoding commented 9 years ago

Can this feature be implemented?

daniele-athome commented 9 years ago

@funcoding I ended up rewriting all objects as views and used a popupwindow. You can find the code kontalk/emojicons, but please note that is not compatible with the current emojicon library.

ankushsachdeva commented 9 years ago

you can use ankushsachdeva/emojicon On 14 Mar 2015 19:20, "Daniele Ricci" notifications@github.com wrote:

@funcoding https://github.com/funcoding I ended up rewriting all objects as views and used a popupwindow. You can find the code kontalk/emojicons, but please note that is not compatible with the current emojicon library.

— Reply to this email directly or view it on GitHub https://github.com/rockerhieu/emojicon/issues/22#issuecomment-80491149.

funcoding commented 9 years ago

@ankushsachdeva I tried out your's and facing some issues with lollipop

funcoding commented 9 years ago

@daniele-athome Thanks. I shall have a look.

dekaru commented 9 years ago

@daniele-athome @ankushsachdeva is it possible to get your projects from gradle?

daniele-athome commented 9 years ago

@dekaru I don't think so, I plan to merge my modifications to @rockerhieu repository.

ankushsachdeva commented 9 years ago

Not as of now, but I plan to do it in future On 17 Mar 2015 21:56, "David Álvarez" notifications@github.com wrote:

@daniele-athome https://github.com/daniele-athome @ankushsachdeva https://github.com/ankushsachdeva is it possible to get your projects from gradle?

— Reply to this email directly or view it on GitHub https://github.com/rockerhieu/emojicon/issues/22#issuecomment-82447608.

bolatov commented 9 years ago

hello @daniele-athome,

any news on merging your modifications?

daniele-athome commented 9 years ago

@bolatov sorry not yet. I'm trying to find the time to do it, but I can't promise anything though. I will do it :-)

Jaymo commented 9 years ago

@ankushsachdeva facing issues using your library on API level >=21 any workaround ?

aalt0 commented 8 years ago

hi, any news on this?