Custom PendingViewHolder implementation

[yayaa]

Hey, i'm back! 😄 https://github.com/rockerhieu/rv-adapter-endless/pull/5

I found some time and update my implementation, actually updated the commits and unnecessary files :) Please take a look, you can even consider commits one by one, they should be meaningful 👍

This solves https://github.com/rockerhieu/rv-adapter-endless/issues/9 and also https://github.com/rockerhieu/rv-adapter-endless/issues/8

Changes

• Gradle updates
• In order to get latest versions of support libraries, minSdk updated as 9
• no context is required in constructor
• layoutId is extracted from constructor
• if no layoutId set, still keeps the default one
• if layoutId is set, inflates and uses
• if PendingViewHolder is set, then uses directly that
• Sample crash fixed
• Sample clear fixed

[yayaa]

How this solves #8

Simple create something like this, and set it to endlessAdapter

public class LoadMoreViewHolder extends RecyclerView.ViewHolder {

    public LoadMoreViewHolder(View view) {
        super(view);
        useFullSpan();
    }

    // Set fullSpan to fit screen
    private void useFullSpan() {
        StaggeredGridLayoutManager.LayoutParams layoutParams = new StaggeredGridLayoutManager
                .LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.WRAP_CONTENT);
        layoutParams.setFullSpan(true);
        itemView.setLayoutParams(layoutParams);
    }

}

[rockerhieu]

Let me have a look...

[yayaa]

How do you wanna proceed with this PR? @rockerhieu Do you have anything else? Do you need me to change something in order to accept or what?

[yayaa]

[rockerhieu]

Hey I'm travelling for Google IO. Will respond when I'm back.

On May 13, 2017 1:28 PM, "Yahya Bayramoğlu" notifications@github.com wrote:

[image: what_now] https://cloud.githubusercontent.com/assets/2683375/26029009/73044308-382b-11e7-8868-9178034130f9.gif

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rockerhieu/rv-adapter-endless/pull/11#issuecomment-301272847, or mute the thread https://github.com/notifications/unsubscribe-auth/ABOPYc6xo0ltSbMXMp0HCKgk9NMNH4lFks5r5hJ9gaJpZM4L3M3J .

[rockerhieu]

Hey @yayaa, wanna update the example to demonstrate the new changes? i.e the ability to use a custom PendingViewHolder?

[yayaa]

@rockerhieu without tools travis fails, added that line back. And updated the sample 👍 please take a look

[rockerhieu]

Waiting for the green badge...

[rockerhieu]

@yayaa I just checked, it seems that tools isn't the cause: https://travis-ci.org/rockerhieu/rv-adapter-endless/builds/238249499. There were some lint errors.

[rockerhieu]

Thanks @yayaa

[yayaa]

Thank you as well 👍 @rockerhieu When you release the version, you can also close the 2 open issues you have :)