rockerhieu / rv-adapter-endless

Endless support for RecyclerView.Adapter
MIT License
107 stars 24 forks source link

The adapter doesn't work when the RecyclerView is inside a NestedScrollView #13

Closed SimonHayotTapptic closed 7 years ago

SimonHayotTapptic commented 7 years ago

Hi,

First of all, thanks for this really useful library !

When the endless RecyclerView is inside a NestedScrollView, the endless adapter makes all the calls to fill the list immediately, without having to reach the bottom of the list, until onDataReady(false) is called.

What can I do ? Thanks !

rockerhieu commented 7 years ago

Can you provided a reproduce project? I'd love to take a look.

On Tue, Aug 1, 2017 at 4:25 PM SimonHayotTapptic notifications@github.com wrote:

Hi,

First of all, thanks for this really useful library !

When the endless RecyclerView is inside a NestedScrollView, the endless adapter makes all the calls to fill the list immediately, without having to reach the bottom of the list, until onDataReady(false) is called.

What can I do ? Thanks !

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rockerhieu/rv-adapter-endless/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/ABOPYdQbtTg4ut8PscbM7g6d4tfSklepks5sTu8hgaJpZM4OpdTF .

--

Hieu. H

Sent from my phone without auto correcton and a dying batte

SimonHayotTapptic commented 7 years ago

Hi,

Turns out that when inside a NestedScrollView, a RecyclerView does not recycle its items, and inflates all of them immediately (which explains the issue that I reported on my first message).

I removed the NestedScrollView, and it now works perfectly.