search

rockerhieu / rv-adapter-endless

Endless support for RecyclerView.Adapter
MIT License
107 stars 24 forks source link

Ability to customize PendingViewHolder and some fixes #5

Closed yayaa closed 8 years ago

yayaa commented 8 years ago

I needed to customize pendingViewHolder -because i use StaggeredGridLayoutManager and i need pendingViews to use fullSpan so in viewHolder i do so. In order to have this happened, i need to create my own view then pass it to the library, so i made that part little bit more flexible.

And also realised that it should not call notifyDataSetChanged everytime, since we have the ability to notify specific portions now. So i made it optional, up to flag.

Finally, since we receive parent object from adapter when it calls onCreateViewHolder, we don't actually need to pass context into this adapter just to create pendingView.

yayaa commented 8 years ago

I guess, because i updated targetSDK to 23 (as Marshmallow) it cannot build automatically. Please see for yourself. Thanks for the library though.

rockerhieu commented 8 years ago

This PR contains too many unnecessary changes, and I don't get your idea either. Sorry my friend, I have to close it.

yayaa commented 8 years ago

You are right, my bad :) Thanks for the library