Updates to pDAO protocol parameters table

rocket-pool / RPIPs

Rocket Pool Improvement Proposals (RPIPs)

Creative Commons Zero v1.0 Universal

17 stars 31 forks source link

Updates to pDAO protocol parameters table #263

Closed sckuzzle closed 3 months ago

orangesamus commented 3 months ago

Should have upper limit of 100% not 1% right? Everything else looks good to me

sckuzzle commented 3 months ago

The guardrails do not have the units of percent. So 1 = 100% already, and I think writing it as <= 100 (without a percent) would be wrong.

I do agree this is confusing to have on the same line as a parameter that is given in units of percent. Maybe the solution is to not use percent as the unit and revert to net value?

orangesamus commented 3 months ago

:+1: