search

rocket-pool / smartnode

The CLI package for Rocket Pool smart nodes.
GNU General Public License v3.0
147 stars 112 forks source link

Networks should not be hard-coded #438

Open jshufro opened 9 months ago

jshufro commented 9 months ago

Smartnode should ideally work for any ethereum network.

If we move network-specific constants and behavior into .yml files, we can trivially support locally run testnets, which will be important for e2e test automation. Additionally, chores like https://github.com/rocket-pool/smartnode/pull/437 become trivial- only one file needs to be updated, with optional "what's changed" update elsewhere.

We can package some 'default' networks with smartnode-install, and read an optional extra-networks.yml from the project directory (~/.rocketpool)

Edit: additionally, putting everything that fornax had to delete in

activescott commented 7 months ago

FYI: I am going to start investigating this one...