search

rocket-pool / smartnode

The CLI package for Rocket Pool smart nodes.
GNU General Public License v3.0
150 stars 112 forks source link

Pass the selected minipool list, instead of every mp #608

Closed 0xfornax closed 4 months ago

0xfornax commented 4 months ago

Fixes a bug where the close minipool command would iterate over every minipool on a node.

github-actions[bot] commented 4 months ago

Coverage Report

github-actions[bot] commented 4 months ago

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ :robot:
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/minipool 0.00% (ø)
Coverage by file ### Changed files (no unit tests) | Changed File | Coverage Δ | Total | Covered | Missed | :robot: | |--------------|------------|-------|---------|--------|---------| | github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/minipool/close.go | 0.00% (ø) | 0 | 0 | 0 | | _Please note that the "Total", "Covered", and "Missed" counts above refer to ***code statements*** instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code._
0xfornax commented 4 months ago

Can't we remove addresses from the function now?

I think that would fit better on the refactor PR we discussed.