V2 Fixed bugs in odao/sec proposals list and details

rocket-pool / smartnode

The CLI package for Rocket Pool smart nodes.

GNU General Public License v3.0

149 stars 112 forks source link

V2 Fixed bugs in odao/sec proposals list and details #647

Closed thomaspanf closed 2 months ago

thomaspanf commented 2 months ago

This PR addresses #635

oDAO

Issue with the oDAO list saying proposals are pending when they are not
Issue with the oDAO detail not displaying details of a valid proposal

Security Council

Security council proposal detail is not showing the detail of a proposal

The commands rp odao proposals details and rp security proposals details and rp odao proposals list should display the correct state now.

github-actions[bot] commented 2 months ago

Coverage Report

github-actions[bot] commented 2 months ago

Merging this branch will not change overall coverage

Impacted Packages	Coverage Δ	:robot:
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/odao	0.00% (ø)
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/security	0.00% (ø)

Coverage by file

### Changed files (no unit tests) | Changed File | Coverage Δ | Total | Covered | Missed | :robot: | |--------------|------------|-------|---------|--------|---------| | github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/odao/proposals.go | 0.00% (ø) | 223 | 0 | 223 | | | github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/security/proposals.go | 0.00% (ø) | 245 | 0 | 245 | | _Please note that the "Total", "Covered", and "Missed" counts above refer to ***code statements*** instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code._