search

rocket-pool / smartnode

The CLI package for Rocket Pool smart nodes.
GNU General Public License v3.0
150 stars 112 forks source link

V2 fixed outdated and hardcoded value in stake rpl #649

Closed thomaspanf closed 2 months ago

thomaspanf commented 2 months ago

This PR fixes a message in stake-rpl that was outdated and hardcoded

Old:

Are you sure you want to stake 543.482558 RPL? You will not be able to unstake this RPL until you exit your validators and close your minipools, or reach over 100% collateral! [y/n]

New:

Are you sure you want to stake 543.482558 RPL? You will not be able to unstake this RPL until you exit your validators and close your minipools, or reach 1086.965117 staked RPL (60% of bonded eth)! [y/n]
github-actions[bot] commented 2 months ago

Coverage Report

github-actions[bot] commented 2 months ago

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ :robot:
github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/node 0.01% (ø)
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/node 0.00% (ø)
github.com/rocket-pool/smartnode/v2/shared/types/api 0.00% (ø)
Coverage by file ### Changed files (no unit tests) | Changed File | Coverage Δ | Total | Covered | Missed | :robot: | |--------------|------------|-------|---------|--------|---------| | github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/node/stake-rpl.go | 0.00% (ø) | 520 | 0 | 520 | | | github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/node/stake-rpl.go | 0.00% (ø) | 295 (+54) | 0 | 295 (+54) | | | github.com/rocket-pool/smartnode/v2/shared/types/api/node.go | 0.00% (ø) | 184 | 0 | 184 | | _Please note that the "Total", "Covered", and "Missed" counts above refer to ***code statements*** instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code._