rocket-pool / smartnode

The CLI package for Rocket Pool smart nodes.
GNU General Public License v3.0
149 stars 112 forks source link

V1 Improved `node deposit` and `node stake-rpl` flow #694

Closed thomaspanf closed 3 weeks ago

thomaspanf commented 4 weeks ago

Included in this PR:

// Old Please choose an amount of ETH to deposit: 1: 8 ETH 1

thomaspanf commented 4 weeks ago

Allow percents but make the user pass -a 5% instead of -a 5, otherwise it's a POLA violation when someone passes -a 5 and it stakes 5% instead of 5 RPL

TIL what a POLA violation is. Nice catch, thank you Patches!

thomaspanf commented 3 weeks ago

Thanks for tightening this up! Looks good now.

Always a pleasure, thanks for the review!