search

rocketeers / rocketeer-slack

Slack notifications for Rocketeer
MIT License
29 stars 8 forks source link

Replace Phlack with maknz/slack #16

Closed mcrumm closed 9 years ago

mcrumm commented 9 years ago

Hello, I'm the maintainer of Phlack. I'm going to be deprecating my library very soon, as I haven't had time to keep it up-to-date. There are a few other slack libraries that are better maintained, and maknz/slack seems like the best replacement for Rocketeer's Slack integration.

This PR does present a backwards-compatibility problem, since Slack not-so-recently changed their Incoming Webhooks structure to use a specific URL for each WebHook, instead of a common services path with a required token parameter (the token is now embedded in the URL, as mentioned in #13).

Unfortunately maknz/slack doesn't support the "legacy" format for Incoming WebHooks, so users of this library will need to update their configurations with the full URL provided by Slack.

I'm don't really use Laravel, so there's probably a better way to integrate the two, given that maknz/slack has built-in Laravel support, but I figured this was at least a good start.

I started this branch from master due to the version constraint issue, but I'm submitting this PR to develop due to the BC-break. If you'd rather have it on master, let me know and I'll re-submit.

Thanks! And thanks for the initial integration. It provided a lot of exposure for my library.

Anahkiasen commented 9 years ago

Hi, sounds good. The PR should indeed be on develop and start from develop, so I can handle tagging and releases separately after that, can you redo the PR off develop?

mcrumm commented 9 years ago

No problem, you'll have it in just a minute.