search

rocketeers / rocketeer-slack

Slack notifications for Rocketeer
MIT License
29 stars 8 forks source link

Move config folder into src to preserve laravel default path conventions #2

Closed rauanmayemir closed 10 years ago

rauanmayemir commented 10 years ago

Main update is moving config folder into src, this way we can preserve laravel path conventions and when you run php artisan config:publish Anahkiasen/rocketeer-slack it won't throw an exception, and updated configurationPath in construct, although one have to rewrite config anyway to set package up.

Also updated minor typo in readme, which cost me a time to realise what is wrong with the service provider. :)

Anahkiasen commented 10 years ago

Does artisan config:publish rocketeer/rocketeer-slack work ? I remember Laravel having problems with PSR4 but I don't remember what worked or not, that and on some occasions custom paths are not followed and stuff.

rauanmayemir commented 10 years ago

No, it doesn't. Why would it? I'm not sure it's somehow related to psr-4.

Laravel follows vendor/package scheme. In this case vendor is anahkiasen and package is rocketeer-slack. Sheer dir names.

That's why I was arguing about config folders structure in rocketeer.

Anahkiasen commented 10 years ago

Yes but the configuration is declared as rocketeer/rocketeer-slack by the TasksQueue class, which is why it should work. It's all a little messy, you can pass paths to the service provider but some are hardcoded and ignore it and all, I need to check again.

Anahkiasen commented 10 years ago

Ok nevermind my rambling, the reason I was hesitant to merge this is I was persuaded I had been able to properly publish the configuration on several projects. But the reason is actually – the configurations were published before the packages were made to follow PSR4 which Laravel doesn't support (and which Taylor hates so I don't see it being supported soon).

Thanks for the PR!