search

rocketeers / rocketeer

Send your projects up in the clouds
http://rocketeer.autopergamene.eu/
MIT License
2.67k stars 217 forks source link

Is Composer required? #602

Open JanisE opened 8 years ago

JanisE commented 8 years ago

Is composer required for Rocketeer to operate? I don't use Composer in the particular project, still Rocketeer complains on both "check" and "deploy" commands that "The Composer package manager could not be found".

Anahkiasen commented 8 years ago

Well, I guess it's not really required, but it is indeed part of the checks Rocketeer does for PHP applications as most apps nowadays use Composer.

Anahkiasen commented 8 years ago

You should be able to disable the check by changing the Check strategy to null in strategies.php

JanisE commented 8 years ago

Which checks would it cancel? I would rather only Composer checks get disabled, not PHP as such (or what it involves). I've commented out the default Composer-related lines in "strategies.php" (install and update hooks), but Rocketeer still checks for Composer.

JanisE commented 8 years ago

There is a similar case with mcrypt: "The following extensions could not be found: mcrypt." As it is a warning and the deployment seems to happen all right, I suppose, it's not critical. Still, every time I deploy, the red error message gives an impression that something is not working correctly. I could get used to it and don't worry, but then it would lose its meaning.

P.S. Oh, and if deploying a stage for the first time, the errors appear even if the "Check" strategy is commented out.

gwagroves commented 8 years ago

@JanisE I don't understand why mcrypt is required by default either.

Required extensions can be defined in composer.json.

IMHO the PHP check should look for ext- requirements in composer.json (if available), and check whether they are installed, rather than just mcrypt.

P.S. @Anahkiasen are you still maintaining Rocketeer? (I completely understand if you've got "open-source fatigue".)

gwagroves commented 8 years ago

Pull request with the required changes: #662

Drop-in replacement that can be used with the current release.