rocketinsights / android-base

A base Android project to start Rocket Android projects off of.
4 stars 0 forks source link

Conditional Navigation and Nested Graph Example #82

Closed IvanToplak closed 3 years ago

IvanToplak commented 3 years ago

General idea is to add more realistic flow to this app. My suggestion is to add:

I've noticed that activity_main.xml has CollapsingToolbarLayout which means it will be shown on every fragment, which is usually not what we want (e.g. SplashFragment, LoginFragment, PhotoFragment and MapsFragment don't need to have toolbar at all). It would be better to move CollapsingToolbarLayout to fragment_main.xml. NestedScrollView is a parent of FragmentContainerView. Scrolling behavior is also something that should be decided per each fragment.

IvanToplak commented 3 years ago

@brimanning @julianfalcionelli what do you think? I would need Rocket logo in vector graphic + the background image or Lottie animation for the splash screen. Who can provide these resources?

brimanning commented 3 years ago

Yeah, that sounds good to me. It probably applies to 95% of our apps, so I'd say go for it. Here's an SVG logo for you, hopefully it converts to a vector drawable easy enough.

Logo.zip

brimanning commented 3 years ago

Actually, here's a better logo to use: rocketinsights_logo_mark.svg.zip.

IvanToplak commented 3 years ago

Actually, here's a better logo to use: rocketinsights_logo_mark.svg.zip.

Nice. I can use this one with blue background.