search

rocketlaunchr / dataframe-go

DataFrames for Go: For statistics, machine-learning, and data manipulation/exploration
Other
1.16k stars 93 forks source link

Add required imports for the README examples #24

Closed MrPowers closed 4 years ago

MrPowers commented 4 years ago

This comment helped me figure out the imports: https://github.com/rocketlaunchr/dataframe-go/issues/23#issuecomment-604007372

Might as well state them explicitly so the code snippets are easier for others to run ;)

Thanks for creating this library!

propersam commented 4 years ago

There is no need for this.

that comment was specific to what you were trying to implement. you needed to import the dataframe and imports subpackage. dataframe-go library has lots of many other subpackages that can be imported as needed...You don't need to import them all at once. This PR does not accont for them all.

and the README already specified the required import statements at specific areas if you check well.... maybe the maintainer will need to make it more obvious but not this way...

thanks for your willingness to contribute..maybe as you continue to use the library and get use to it..you will likely discover much better areas that need improvement...

MrPowers commented 4 years ago

@propersam - thanks for taking a look. I wouldn't consider my bug specific to what I am trying to implement - it's from the README.

You mentioned that the README already specifies the import section. Can you please point me to where the README tells the user the import statement that's necessary to run the README example? Thanks again for the help and sorry for being a Go noob!!

propersam commented 4 years ago

Please refer to this https://godoc.org/github.com/rocketlaunchr/dataframe-go to access the complete doc for this go library.

Go Developer Tip: Any go project on github have an autogenerated doc page on this link.. https://godoc.org/-the-github-link-here

this is how go developers learn to work with Go packages.

Based on ur experience ..the README will likely be updated to make the imports clear enough